GRAPHICS: Fix cursor mask regressions #4746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recreate. Fixes cursor transparency breaking after toggling fullscreen mode on Windows.
elasota
force-pushed
the
fix-gl-context-cursor
branch
from
32bb402
to
44789bb
Compare
elasota
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes two regressions from PR #4713
First, cursor transparency was breaking when toggling fullscreen mode on Windows (alt+enter) and possibly other platforms because the cursor texture was still mapped to an ID from the destroyed GL context.
Second, cursor mask transparency wasn't being applied when using scalers that can scale cursors (Normal and AdvMame), which was causing a border to appear around them in some games due to it being filled with the key color, despite the key color not actually being keyed out.