Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRAPHICS: Fix cursor mask regressions #4746

merged 2 commits into from Mar 5, 2023


Copy link

@elasota elasota commented Feb 27, 2023

Fixes two regressions from PR #4713

First, cursor transparency was breaking when toggling fullscreen mode on Windows (alt+enter) and possibly other platforms because the cursor texture was still mapped to an ID from the destroyed GL context.

Second, cursor mask transparency wasn't being applied when using scalers that can scale cursors (Normal and AdvMame), which was causing a border to appear around them in some games due to it being filled with the key color, despite the key color not actually being keyed out.


Fixes cursor transparency breaking after toggling fullscreen mode on Windows.
@elasota elasota changed the title GRAPHICS: Properly handle cursor mask texture in GL context teardown/recreate GRAPHICS: Fix cursor mask regressions Mar 4, 2023
Copy link

sev- commented Mar 5, 2023

Thank you!

@sev- sev- merged commit 2841b99 into scummvm:master Mar 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
2 participants