ANDROID: Make SAF lookup faster #4761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caches all files in the directory once and looks up at the cache then. This is still slow when the file doesn't exist. Handling this case is quite complicated because we need to take into account the cache eviction.
antoniou79
reviewed
Mar 3, 2023
|
#4762 has been favoured over this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This fixes slowness at startup when there are many games.
The
getChildwas called once for each folder and while iterating over many entries, it only cached the result it was interested in.getChildnow callsgetChildrenwhen an entry is not in cache. This caches the whole folder and speeds up look ups for the same folder.The cache is increased to take into account folder with more than 1000 elements (now 10000).
Currently, if a folder has more than 10000 items, elements could be seen as not found.