SLUDGE: Implement MKV decoding so WebM videos can be played. #4766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taken from 9690075dccb7cbe25201bc74a467cdc6e3f41e7b from https://github.com/webmproject/libwebm
The wrong if condition was causing videos to skip playing after 1/2 frames.
The solution works by ensuring that we have atleast 10 audioBuffers in the audio stream
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This pull implements MKV decoding which is primarily used by the SLUDGE engine to play webM videos.
@sev- did most of the work here (importing and porting the original code to scummvm). I worked on cleaning it up, fixing bugs and getting audio playback to work.
Games this was tested against:
In our limited testing, the A/V sync, sometimes did break. However, we concluded it was only a minor issue.
Thanks to @sev- for guiding me and helping me out!