Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLUDGE: Implement MKV decoding so WebM videos can be played. #4766

merged 35 commits into from Mar 5, 2023


Copy link

This pull implements MKV decoding which is primarily used by the SLUDGE engine to play webM videos.
@sev- did most of the work here (importing and porting the original code to scummvm). I worked on cleaning it up, fixing bugs and getting audio playback to work.
Games this was tested against:

  • The secret of the tremendous corporation

In our limited testing, the A/V sync, sometimes did break. However, we concluded it was only a minor issue.
Thanks to @sev- for guiding me and helping me out!

sev- and others added 30 commits March 4, 2023 12:06
Taken from 9690075dccb7cbe25201bc74a467cdc6e3f41e7b from
The wrong if condition was causing videos to skip playing after 1/2 frames.
The solution works by ensuring that we have atleast 10 audioBuffers in the audio stream
Copy link

sev- commented Mar 5, 2023

Thank you!

@sev- sev- merged commit 234e1ca into scummvm:master Mar 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
2 participants