Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEWS: Update German translation for recent adibou2 additions #4783

Closed
wants to merge 1 commit into from

Conversation

CrystalBen
Copy link

Some German Translations
Changed Adi Junior to Addy Junior
Changed Read/Count 4 & 5 to Lesen/Rechnen 4 & 5
Changed Read/Count 6 & 7 to Lesen/Rechnen 6 & 7

Some German Translations
Changed Adi Junior to Addy Junior
Changed Read/Count 4 & 5 to Lesen/Rechnen 4 & 5
Changed Read/Count 6 & 7 to Lesen/Rechnen 6 & 7
@@ -61,7 +61,7 @@ Umfangreichere Informationen über die Änderungen des aktuellen Codes findest D
- Unterstützung für Obsidian hinzugefügt.
- Unterstützung für Added support for Pink Panther: Passport to Peril hinzugefügt.
- Unterstützung für Pink Panther: Hokus Pokus Pink hinzugefügt.
- Unterstützung für Adibou 2 (Adi Junior) "Environment", "Read/Count 4 & 5" und "Read/Count 6 & 7" hinzugefügt.
- Unterstützung für Adibou 2 (Addy Junior) "Environment", "Lesen/Rechnen 4 & 5" und "Lesen/Rechnen 6 & 7" hinzugefügt.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the title screen, we should leave it as "Adi", at least that's how the version I have shows it. I agree with "Lesen/Rechnen" though.
scummvm-adibou2-win-de-00001

@lotharsm
Copy link
Member

lotharsm commented Mar 7, 2023

Thank you!

Could you please modify the commit message according to our guidelines?

It should be prefixed with the subsystem you target, e.g. you can choose

NEWS: Update German translation for recent adibou2 additions

@CrystalBen CrystalBen changed the title Added some German Translations NEWS: Update German translation for recent adibou2 additions Mar 7, 2023
@CrystalBen
Copy link
Author

i applied the changes

@CrystalBen
Copy link
Author

is this a picture of a german version?

@lotharsm
Copy link
Member

lotharsm commented Mar 7, 2023

is this a picture of a german version?

Yes, this screenshot is taken with the following version:

	{
		"adibou2",
		"ADI Jr. (Packard Bell OEM)",
		AD_ENTRY1s("intro.stk", "80588ad3b5510bb44d3f40d6b07b81e7", 956328),
		DE_DEU,
		kPlatformWindows,
		ADGF_NO_FLAGS,
		GUIO0()
	},
	kGameTypeAdibou2,
	kFeatures640x480,
	0, 0, 0
},

@CrystalBen
Copy link
Author

ah okay

@lotharsm
Copy link
Member

lotharsm commented Mar 9, 2023

Do you want to add the changes to your PR/commits or do you want me to quickly apply the changes manually? :-)

@CrystalBen
Copy link
Author

can you please apply these changes for me?

@lotharsm
Copy link
Member

Thank you, added in 7fc6a3a.

@lotharsm lotharsm closed this Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants