GLK: ADRIFT: Add detection for new games (B-F) #4797
Conversation
| @@ -35,10 +35,14 @@ const PlainGameDescriptor ADRIFT_GAME_LIST[] = { | |||
| { "30seconds", "30 Second" }, | |||
| { "3monkeys", "Three Monkeys, One Cage" }, | |||
| { "achtung", "Achtung Panzer!" }, | |||
| { "adrbedlam", "Bedlam" }, | |||
| { "adrbluesky", "Blue Sky" }, | |||
| { "adrcrimescene", "The Crime Scene" }, | |||
There was a problem hiding this comment.
For consistency, these entries should have "adrift" after the gamename:
bedlamadrift , blueskyadrift etc.
You could also change the "asylum" entry to "asylumadrift"
There was a problem hiding this comment.
Got it. I'll fix when I'll add another commit to this PR for [D - F] block
There was a problem hiding this comment.
You could also do the changes, stage the file and commit --amend
Then force push to your branch and the PR will update automatically
There was a problem hiding this comment.
I really don't want to make a mess here because I'm still learning git!
| @@ -695,8 +888,8 @@ const GlkDetectionEntry ADRIFT_GAMES[] = { | |||
| // ADRIFT One-Hour Game Competition 3 | |||
| DT_ENTRY0("1hgforum2", "5a534ac4e39a319022d145094c46930a", 11185), | |||
| DT_ENTRY0("1hgcrm", "d97d1ff8f01a61fb477b76df65c77795", 15432), | |||
| DT_ENTRY1("1hgasdfa", "Competition Release", "fccb2fb890d554263d5f55bc02220ab8", 6440), | |||
| DT_ENTRY1("1hgdemonhunter", "Competition Release", "ca37aaf35fb15a40a7f5f8caa1475112", 4169), | |||
| DT_ENTRY1("1hgasdfa", "Comp Rel", "fccb2fb890d554263d5f55bc02220ab8", 6440), | |||
There was a problem hiding this comment.
Not really a fan of this change. "Comp Rel" is not really clear, I'd keep "Competition Release".
Same thing for the other entries, I'd rather use "Release" instead of just "Rel"
There was a problem hiding this comment.
@tag2015 PR updated. Can it be merged now if ok?
MarcoBorrini99
changed the title
|
I haven't had the time to look at the new entries yet, but I'd like to mention two things:
|
Ok, I'll try to join Discord channel
Of course, I only missed once to check the building and that time was faulty... |
|
Thanks a lot for your work! Merged manually |
GLK: ADRIFT: Add detection for new games
This commit add/fixes entries from the following sources:
This PR can already be merged.