Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGINES: Update autosave time before adjusting interval #4799

Merged

Conversation

macca8
Copy link
Contributor

@macca8 macca8 commented Mar 10, 2023

When an autosave fails, or is skipped by the user, the next autosave attempt is scheduled for 5 minutes, regardless of the user's selected autosave interval.

Fixes an issue where the adjusted next autosave interval is incorrectly applied to the expired _lastAutosaveTime value, resulting in the next autosave being called immediately, and repeatedly, until the autosave is able to proceed.

Fixes the 'Skip autosave' button and Escape key being unable to dismiss the in-game warning dialog from the screen.

Correctly adjusts interval until next autosave attempt to 5 minutes, regardless of user’s selected autosave interval.
@sev-
Copy link
Member

sev- commented Mar 16, 2023

Thank you!

@sev- sev- merged commit 746665d into scummvm:master Mar 16, 2023
8 checks passed
@macca8 macca8 deleted the fix-adjusted-autosave-interval-calculation branch March 17, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants