LURE: Original VGA background color in popup menus #4805
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In the original VGA DOS game all GUI dialogs have a dark gray background
color. However in the ScummVM implementation the background color for
popup menus, which are the ones that appear when you right-click, is
black. The ScummVM EGA version works as intended.
Probably this issue was due to the difficulty of knowing at which index
the dark gray color was in all the different palettes. From my
understanding of the LURE engine and VGA, different graphic resources
could have different color palettes.
My solution was to copy the element side lines when the dialog needs to
be emptied, instead of filling a rectangle with solid black. In my
second commit there's even a more strict fix, in which I copy only the
element background, because there is no need to draw the wooden side
borders again.