VIDEO: Fix VPX build for various platforms #4807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aquadran
reviewed
Mar 12, 2023
aquadran
reviewed
Mar 12, 2023
| @@ -5309,7 +5296,7 @@ long VideoTrack::Parse(Segment* pSegment, const Info& info, | |||
| long long stereo_mode = 0; | |||
|
|
|||
| double rate = 0.0; | |||
| std::unique_ptr<char[]> colour_space_ptr; | |||
| Common::ScopedPtr<char, Common::ArrayDeleter<char>> colour_space_ptr; | |||
There was a problem hiding this comment.
STL, makes me wonder who reviewed this in first place...
There was a problem hiding this comment.
@aquadran That was me, and moreover, I did add it in the first place...
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
AppleTV and iOS need the libvpx.a file to be added to their build flags like other libraries.
MKV decoder needs proper support for Tremor. This is copied from Theora decoder.
libvpx can be built statically. In this case additional libraries may be needed (like pthread for multithreaded decoding).
Without this, it fails to build on platforms like Vita.
Finally, patch MKV parser to make it use our own objects instead of STL ones. This makes the code compile under MacOS i386 toolchain.
As the C++ headers are replaced by our own (which include C versions of them),
LLONG_MAXneeds to be redefined on some platforms (newlib based ones) and isnan can't be defined as a function as it may be a macro.Without this PR, new toolchains which have libvpx can't be deployed.