/ scummvm Public
NUVIE: Fix Ultima 6 crash on loading save #4808
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
Fix a use-after-free bug. The chain of events causing it is as follows:
In-game the user changes the current view (e.g. by pressing TAB to go to inventory view). The user next presses ESC to open the GameMenuDialog and then clicks the "Load Game" button. A save slot is selected and then loaded.
The resulting call chain is:
Control then returns to GUI_Button::Activate_button() with "this" containing the address of the freed button.
An attempt to call Redraw() finally dereferences the invalid pointer.
This is fixed by calling loadGameDialog() before close_dialog().