GUI: Only use a transparent colour for BMP images #4819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lephilousophe
reviewed
Mar 17, 2023
| @@ -721,6 +724,9 @@ bool ThemeEngine::addBitmap(const Common::String &filename, const Common::String | |||
| delete surf; | |||
|
|
|||
| surf = new Graphics::ManagedSurface(tmp2); | |||
|
|
|||
| if (surf->hasTransparentColor()) | |||
| surf->setTransparentColor(surf->getTransparentColor()); | |||
There was a problem hiding this comment.
This looks kind of counter intuitive.
Is this really what was intended?
|
@ccawley2011 what is the status of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
By doing this, we can assume that colour keys and alpha channels are mutually exclusive, which allows for future optimisation.