MOHAWK: RIVEN: Fix autosave on exit during cutscene #4820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reposition autosave call to precede any changes to game state that follow the exit call.
sev-
reviewed
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
An issue exists where an autosave is performed when exiting the game during a cutscene, even though normal saving is disabled at this time.
When exiting the game during a cutscene, the game skips ahead to the first interactive frame outside the cutscene, then completes the exit.
Currently, the autosave is called after this change to the game state, creating the opportunity to complete an unexpected save that skips the unseen portion of the cutscene.
Fixed by repositioning the saveAutosaveIfEnabled() call to a position before the game state is changed, ensuring the autosave is always attempted based on the game state, and save condition, existing at the time the exit call is initiated.
In this example, the autosave fails to complete, as expected.
Fixes bug 11440.