Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOHAWK: RIVEN: Fix autosave on exit during cutscene #4820

wants to merge 2 commits into
base: master
Choose a base branch


Copy link

@macca8 macca8 commented Mar 17, 2023

An issue exists where an autosave is performed when exiting the game during a cutscene, even though normal saving is disabled at this time.

When exiting the game during a cutscene, the game skips ahead to the first interactive frame outside the cutscene, then completes the exit.

Currently, the autosave is called after this change to the game state, creating the opportunity to complete an unexpected save that skips the unseen portion of the cutscene.

Fixed by repositioning the saveAutosaveIfEnabled() call to a position before the game state is changed, ensuring the autosave is always attempted based on the game state, and save condition, existing at the time the exit call is initiated.

In this example, the autosave fails to complete, as expected.

Fixes bug 11440.

Reposition autosave call to precede any changes to game state that follow the exit call.
engines/mohawk/riven.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
2 participants