Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'unused variable' warnings #529

Closed
wants to merge 1 commit into from
Closed

Conversation

@fingolfin
Copy link
Contributor

fingolfin commented Nov 8, 2014

This fixes a bunch of warnings about unused variables I receive when compiling ScummVM on Mac OS X 10.8

Review on Reviewable

@digitall
Copy link
Member

digitall commented Nov 23, 2014

@fingolfin : Thanks for the fixes or at least for flagging up these issues. I don't think merging this as-is is OK as it resulting in a load of commented out code...

@digitall
Copy link
Member

digitall commented Nov 23, 2014

However, the engine authors for AGI ( @sev- ), MADS ( @bluegr ), MOHAWK Riven ( @clone2727 ), NEVERHOOD, SWORD25 and core team for common/unzip.cpp, image/codecs/mjpeg.cpp and gui/EventRecorder.cpp should deal with closing the issues either by fixing the errorneously unused code or by deleting...

@bluegr
Copy link
Member

bluegr commented Dec 7, 2014

Thanks for your work! This looks good to be merged. All of the code commented out is unused.

I'll try and split this into separate commits, as this can't be committed as one...

Regarding AGI: I'll set it to use some of the unused code in a subsequent commit.

@bluegr
Copy link
Member

bluegr commented Dec 7, 2014

All of this has been pushed to master as several different commits. I've added the Amiga palettes to AGI too.

Closing

@bluegr bluegr closed this Dec 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.