Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSCUMM: detection fixes #530
Merged
Conversation
BenCastricum
force-pushed the
BenCastricum:detection_fixes
branch
2 times, most recently
from
0e1cbf8
to
c246f4a
BenCastricum
force-pushed the
BenCastricum:detection_fixes
branch
from
c246f4a
to
7dda44b
BenCastricum
force-pushed the
BenCastricum:detection_fixes
branch
from
7dda44b
to
ae630f3
|
It would be best to revert the English detection changes for Freddi Fish 1, Putt-Putt Goes to the Moon and Putt-Putt Saves the Zoo. Since they appear to be used by multiple language, and we can't be sure the file sizes are the same either. |
BenCastricum
force-pushed the
BenCastricum:detection_fixes
branch
from
ae630f3
to
1aed15d
|
ok, I removed those. |
|
Looks good to be merged now. |
BenCastricum
force-pushed the
BenCastricum:detection_fixes
branch
from
1aed15d
to
30038ef
|
Thanks for the detection fixes - these look OK to be merged. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
BenCastricum commentedNov 10, 2014
This adds detection for all the Kelloggs Mini Games, and a few other fixes as well.