DEVTOOLS: Add packaging scripts for DLC #5300
Conversation
…cript (package.py)
…name constraints Constraints: Asset pack names must start with a letter and can only contain letters, numbers, and underscores.
… to same as docker bb
|
Where does |
| @@ -0,0 +1,92 @@ | |||
| #!/usr/bin/env python3 | |||
| @@ -0,0 +1,921 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
How is this file generated? Do we have to have it in the repo, or it could be generated on demand?
If not, then how it should be updated after the config.proto file is changed?
There was a problem hiding this comment.
Yes it can be generated on demand by using protobuf-compiler (cmd: protoc --python_out . config.proto).
There was a problem hiding this comment.
this needs the protobuf compiler though, which is not the same as having installed the python protobuf package.
There was a problem hiding this comment.
Yes, the protobuf-compiler needs to be installed on the user's pc, which makes the protoc command available. The protobuf-compiler is only needed for generating the new _pb2.py file (if config.proto is changed or if available version of python-protobuf is not supported) and is not required for the packaging process. The packaging process requires this _pb2.py file and the python-protobuf package (now available in docker-bb).
| @@ -0,0 +1,197 @@ | |||
| syntax = "proto3"; | |||
There was a problem hiding this comment.
Where does this file come from? What is its license?
There was a problem hiding this comment.
I took it from: https://github.com/android/app-bundle-samples/blob/main/PlayAssetDelivery/BundletoolScriptSample/config.proto
However, it seems that config.proto in above repo is from the bundletool repository.
The license of both the source code is Apache 2.0.
| "platform": "pc" | ||
| }, | ||
| "size": "69377781", | ||
| "url": "https://downloads.scummvm.org/frs/extras/Beneath%20a%20Steel%20Sky/bass-cd-1.2.zip" |
There was a problem hiding this comment.
How to describe a game that consists of many files?
There was a problem hiding this comment.
@sev- Can you give an example? Do you mean the game is available to download in multiple .zip parts (due to its large size)?
There was a problem hiding this comment.
No, I mean, a game that will be represented in different packages, but that consists of many files. Or do you mean that for preparing a game for distribution, we must first zip it?
It is from the releases of https://github.com/google/bundletool. |
|
Thanks, merging. You may continue development in-tree |
This PR adds packaging scripts to prepare the games (DLCs) and, if applicable, bundle them with base ScummVM binary in formats recognized by different distribution platforms.
The main package.py produces a ready-to-upload packaged file to upload for the provided distribution platform. The ready-to-upload file can either be a packaged standalone game data (DLC) or bundled together with base ScummVM binary, depending on the requirement of distribution stores. Eg. For the Android Play Store, the DLCs must be bundled together with the base ScummVM APK in an Android App Bundle format.
This PR only contains entry for packaging DLCs for the Android Play Store and includes the required dependencies (3rd party scripts from here, bundletool.jar, etc.) in
scripts/android.