IOS7: Utilise Arm Neon optimisation #5301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccawley2011
reviewed
Aug 29, 2023
engines/ags/lib/allegro/surface.cpp
Outdated
| @@ -183,7 +183,7 @@ void BITMAP::draw(const BITMAP *srcBitmap, const Common::Rect &srcRect, | |||
| drawInnerGeneric<2, 1, false>(args); | |||
| return; | |||
| } | |||
| #ifdef SCUMMVM_NEON | |||
| #if defined(SCUMMVM_NEON) && (defined(__ARM_NEON__) || defined(__ARM_NEON)) | |||
There was a problem hiding this comment.
This will stop runtime detection from working on platforms where NEON is optional since only the files with the actual NEON code is built with -fpu=neon, which is what defines ARM_NEON.
There was a problem hiding this comment.
Ok, I will try to solve it within the backend itself
|
There's an additional change in PR #5286 that enables NEON in ARMv7 ./configure builds that you might want to add to this one. |
The blit-neon.cpp file is only added to the project if the flag SCUMMVM_NEON is defined. However some backends, e.g. iOS, adds the definition of SCUMMVM_NEON in create_project so the file can be added to the project during configuration. The same backend can then unset the definition due to changing build target, the iOS simulator in this example, which runs can run on x86_64 hosts which doesn't support NEON. Since the project still include the source file it will be compiled. Make sure to not build the file if not SCUMMVM_NEON is defined at compile time.
The surface_neon.cpp file is only added to the project if the flag SCUMMVM_NEON is defined. However some backends, e.g. iOS, adds the definition of SCUMMVM_NEON in create_project so the file can be added to the project during configuration. The same backend can then unset the definition due to changing build target, the iOS simulator in this example, which runs can run on x86_64 hosts which doesn't support NEON. Since the project still include the source file it will be compiled. Make sure to not build the file if not SCUMMVM_NEON is defined at compile time.
Add the definition of SCUMMVM_NEON in create_project for the iOS and tvOS targets. Do not add the same definition to corresponding simulators since they can run on x86_64 hosts, which for obvious reasons lacks support for NEON.
Make use of the NEON optimisations in iOS and tvOS.
The SCUMMVM_NEON definition is alredy added by default for aarch64 host cpus. NEON is also supported on iOS devices running on armv7 cpus. Make sure to enable NEON for all ios7 devices.
larsamannen
force-pushed
the
ls_enable_neon_ios
branch
from
2356570
to
2b9ab01
Compare
|
@ccawley2011 updated |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables SCUMMVM_NEON for iOS/tvOS, simulators running on x86_64 excluded.
It also add extra preprocessor checks that ARM_NEON really is available if SCUMMVM_NEON is set.
To allow for Arm NEON optimisations SCUMMVM_NEON, ARM_NEON or __ARM_NEON have to be defined.
Else it will bail out do use the default non-optimised functions.
Replaces #5286