Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST: Improve tests #5306

Merged
merged 2 commits into from Sep 2, 2023
Merged

TEST: Improve tests #5306

merged 2 commits into from Sep 2, 2023

Conversation

lephilousophe
Copy link
Member

This PR contains two things:

  • it makes warnings silent by default in tests as the INI tests and blending are quite spammy while their output isn't really useful while just checking if tests are good.
  • it also adds a pretty-printer for Common::String. This allows to display the string content instead of raw bytes of the class.

@lephilousophe
TEST: Silence logs by default
ecf2d7d 
Else tests on INI parser spam with expected warnings.
@lephilousophe
TEST: Add CxxTest ValueTraits for String
fb52ae3 
This allows pretty printing them when there is an assertion failure
@sev-
Copy link
Member

sev- commented Sep 2, 2023

Thank you!

@sev- sev- merged commit 3b4e8a4 into scummvm:master Sep 2, 2023
8 checks passed
@lephilousophe lephilousophe deleted the improve-tests branch September 2, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lephilousophe @sev-