COMMON: Refactor ArchiveMember directory support #5309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iling asterisk wildcards
…ren to ArchiveMember
…e directory detection. Add support for listChildren and isDirectory.
…o process directories
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few new functions:
Archive::isPathDirectory: Returns true if a specified path is a directoryArchiveMember:isDirectory: Returns true if the archive member is a directoryArchiveMember::listChildren: Lists the children of an archive memberThis also introduces some potentially-breaking functionality changes:
Common::String::matchStringwill no longer match excluded characters with a trailing asterisk. This was apparently unintentional, and causeslistMatchingMembersand similar to not behave the same way forFSDirectoryas it does for other archive types that support listing members.ZipArchivenow strips trailing path separators from directory entries. The directory detection code has also been updated to detect directory entries without trailing path separators from the external file attributes field.Finally, it updates Sword 2.5's package manager to be compatible with this change.
Further testing is needed.