SCUMM: Add settings entry for Mac Loom #5312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the Macintosh b/w render mode available for it, alongside the default Macintosh one.
eriktorbjorn
force-pushed
the
mac-loom-settings-entry
branch
from
3eaa11b
to
c24ef5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without it, ScummVM will use a generic "No AdLib" entry, and that doesn't have the Macintosh b/w render mode.
I'm submitting it as a pull request since I'm uncertain if there are further adjustments to be done to the settings entry. The MDT_PCSPK / MDT_PCJR is needed, because that's the case used for the Mac sound as well in readSoundResourceSmallHeader().
The GUIO_ORIGINALGUI is also a bit misleading, but we do implement the Mac message dialogs at least, e.g. pausing the game.