TINSEL: Initialize remaining sound reels when loading old save #5319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAX_SOUNDREELS was increased from 5 to 10 in commit 40f57bd67b6cc3c5b106b0f6f297d466f90dc972.
When loading an old save with less than 10 reels, the remaining ones are currently not reset. (The global holding the reels (Tinsel::g_soundReels) is, but the buffer the data is loaded into (static Tinsel::SAVED_DATA Tinsel::g_sgData) is not. Its contents are then memcpy'ied over).
This might only be a theoretical problem, since it would require creating/loading a save with more than 5 active reels first before then loading a save in the old format.