Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TINSEL: Initialize remaining sound reels when loading old save #5319

merged 1 commit into from Sep 11, 2023


Copy link

MAX_SOUNDREELS was increased from 5 to 10 in commit 40f57bd67b6cc3c5b106b0f6f297d466f90dc972.

When loading an old save with less than 10 reels, the remaining ones are currently not reset. (The global holding the reels (Tinsel::g_soundReels) is, but the buffer the data is loaded into (static Tinsel::SAVED_DATA Tinsel::g_sgData) is not. Its contents are then memcpy'ied over).

This might only be a theoretical problem, since it would require creating/loading a save with more than 5 active reels first before then loading a save in the old format.

Copy link

bluegr commented Sep 11, 2023


@bluegr bluegr merged commit 15d85c2 into scummvm:master Sep 11, 2023
8 checks passed
@PushmePullyu PushmePullyu deleted the tinsel-dw2-init-soundreels branch September 21, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
2 participants