DIRECTOR: fix loading cursor from main archive #5320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug introduced in 9aa0958. That commit limited reading cursors to open res files, not all *seen* res files. However, that broke the custom cursor in Small Stories for Sleepless Nights for Mac (nemurenu-mac-ja), which stores its cursor in the game's main archive which is already closed at the time the cursor gets loaded.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in 9aa0958. That commit limited reading cursors to open res files, not all seen res files. However, that broke the custom cursor in Small Stories for Sleepless Nights for Mac (nemurenu-mac-ja), which stores its cursor in the game's main archive which is already closed at the time the cursor gets loaded.
I scoped this to Mac right now because that's the platform I encountered this on, and the other branches are specific to Windows. However, I'm not sure if this behaviour is actually Mac-specific. @sev- also suggested that possibly the main cast should always be present in
_allOpenResFiles.Broken:
Fixed: