SCUMM: Workaround line glitch in Freddi 3 #5325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! Can you please add a commit in which you add the Enable Enhancements checkbox to this game? |
|
Thanks! 😄 merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workarounds the graphical glitch in Freddi Fish 3 described in https://bugs.scummvm.org/ticket/13532
This is caused by a frame with this flashing line in costume itself (costume 258, frame 35)
I haven't figured a way to avoid drawing the whole frame (ignoring the bottom line)
But this solution may make the line disappear anyway, although at the cost of Freddi's eye being drawn less accurately*:
*Luther was just blinking when the screenshot was taken