Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCUMM: Make subtitle color change optional #5327

Merged
merged 1 commit into from Sep 13, 2023

Conversation

BLooperZ
Copy link
Contributor

This marks the subtitle color change introduced in #4134 as optional game-specific enhancement.

@bluegr
Copy link
Member

bluegr commented Sep 12, 2023

Nice work!
I believe it would be good to wait for #5102 before merging this one

@AndywinXp
Copy link
Contributor

Nice work! I believe it would be good to wait for #5102 before merging this one

Hi! My plan is to help eriktorbjorn with that, but currently I'm rushing through a bunch of other stuff. It's still gonna be a little while though (surely before 2.8.0) 🙂

As long as this enhancement is added to the wiki, I see no harm in merging this before the other PR. After all, I'm the one who is going to mark the category of every current enhancement 😄

@AndywinXp
Copy link
Contributor

Thanks! Merging...

@AndywinXp AndywinXp merged commit db03ce2 into scummvm:master Sep 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants