Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GOB: split Adibou 1 CD versions into seperate gameid #5328

Closed
wants to merge 1 commit into from
Closed

GOB: split Adibou 1 CD versions into seperate gameid #5328

wants to merge 1 commit into from

Conversation

BJNFNE
Copy link
Contributor

@BJNFNE BJNFNE commented Sep 10, 2023

No description provided.

@BJNFNE BJNFNE force-pushed the gob-split-adibou1cd-gameid branch 2 times, most recently from a5f1d84 to 4189c4d Compare September 10, 2023 19:36
@tag2015
Copy link
Contributor

tag2015 commented Sep 10, 2023

Sorry, but this doesn't look correct to me.
CD and standard versions should share the same id and be identified using the appropriate flag (the ADGF_CD in this case, which can also be checked in-engine as needed).
Using different ids also means that we need to create different icons which is redundant.
I know that there are other games in the GOB engine that are in the same situation, but those are the entries that should be changed, not the other way around...

@BJNFNE
Copy link
Contributor Author

BJNFNE commented Sep 11, 2023

@tag2015 which GOB games are you meaning that should be changed?

@sev-
Copy link
Member

sev- commented Sep 11, 2023

This is indeed incorrect and has no real point.

@sev- sev- closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@BJNFNE @tag2015 @sev-