GOB: add opcode for specfic Adibou 2 German version #5331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BJNFNE
force-pushed
the
gob-adibou2-appligarden
branch
from
514c948
to
188c0ee
Compare
|
So, you're stubbing that opcode. What does it actually do? Is there any functionality missing when stubbing it out? |
Its just continues |
|
Does the game crash because of the missing opcode? Or is it just a warning displayed in the log? |
Just Prints an Warning message |
|
I specifically advised you to avoid warnings-related PRs two weeks ago: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for adding the opcode for following reason: if you leave in one specfic German version of Adibou 2 (ADI Junior 2) the Application and want to return to the Garden of Adibou, Then the Console was printing an unimplemented opcode, so we can get rid of this message,