COMMON: Implement Cue sheet parser #5334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By request of @mistydemeo
This is an extensible parser for Cue sheets. It does not implement all the known tags, I decided to go with a pragmatic approach and add them as long as I see unprocessed commands. The missing things are reported via warnings and full parsing trace is visible at debug level 5.
The class does not implement any access API to the parsed data structures, as I need more information regarding usage. This is a trivial task since the data is kept in a neat hierarchy with nested
Common::Arraylists.Also, I added a simple test to the Director engine, so you could see the implementation in action. To invoke the test, run
./scummvm -p engines/director/lingo/tests --debugflags=text -d5 --auto-detectAny feedback is welcome.