CREATE_PROJECT: Default to C++11 and support MacPorts /opt/local/lib #5376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have C++11 features in use outside engines as well now.
This should hopefully be fairly harmless for other platforms, as well as for Homebrew-users. But it doesn't seem like CMake adds /opt/local/lib to it's linking setup by default.
bluegr
reviewed
Oct 21, 2023
| @@ -174,6 +176,9 @@ if (TARGET SDL2::SDL2) | |||
| endif() | |||
| include_directories(${SDL2_INCLUDE_DIRS}) | |||
|
|
|||
| # Explicitly support MacPorts (hopefully harmless on other platforms) | |||
There was a problem hiding this comment.
Will this work in Windows platforms? There's a WIN32 define, perhaps it can be used for this as well?
|
Merging this, but we indeed have to check if it breaks Windows cmake builds. But since I did not hear it used much, I'd wait until somebody is complaining. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small changes to the CMake generator to let it support macOS with libraries installed from MacPorts.
Also an adjustment to support C++11 globally in the generated CMake files.
Pushing this as a PR in case someone disagrees with the global adding of /opt/local/lib.