Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOB: use infinite Flowers flag for Adibou2 german version #5394

Closed
wants to merge 1 commit into from

Conversation

BJNFNE
Copy link
Contributor

@BJNFNE BJNFNE commented Oct 26, 2023

No description provided.

@sdelamarre
Copy link
Contributor

Did you actually check that this workaround works on your German version? It is highly dependent on the variable indexes in the .TOT files, that can change between versions.

@sev-
Copy link
Member

sev- commented Oct 28, 2023

Yes, a playtest is required.

@sev-
Copy link
Member

sev- commented Oct 30, 2023

Switching it to draft in the meantime. @BJNFNE when will you plan the playtest?

@sev- sev- marked this pull request as draft October 30, 2023 22:27
@BJNFNE
Copy link
Contributor Author

BJNFNE commented Oct 31, 2023

Switching it to draft in the meantime. @BJNFNE when will you plan the playtest?

@sdelamarre found out that this version, uses other script offsets so the workaround has to be updated first.

@sdelamarre
Copy link
Contributor

sdelamarre commented Oct 31, 2023

@BJNFNE since I confirmed from the script you sent me that your version has the bug, can you do the following:

  • ensure you are able to reproduce it by playtesting (it is not trivial to reproduce so it may require some practicing)
  • try to fix the workaround in ScummVM code. Basically it is just a matter of fetching the current script output
    (_vm->_game->_script->pos()) there in your version, and adding it to the condition:
(_vm->_game->_script->pos() == 30743 ||
_vm->_game->_script->pos() == 31074 ||
_vm->_game->_script->pos() == 31109) 
  • check that it fixes the bug by doing a new playtest
  • update the PR

@BJNFNE
Copy link
Contributor Author

BJNFNE commented Oct 31, 2023

Thanks i try that later at the evening 👍

@bluegr
Copy link
Member

bluegr commented Nov 6, 2023

@BJNFNE any news on this?

@BJNFNE
Copy link
Contributor Author

BJNFNE commented Nov 6, 2023

@BJNFNE any news on this?

It Looks like i am always to slow to trigger the Bug, so i gave @sdelamarre the version. Maybe he has made some progress.

@sdelamarre
Copy link
Contributor

Closing this since you gave up on the task @BJNFNE. I will probably not look at this low-priority enhancement before long, so feel free to ping me if you want to retry and need more guidance.

@sdelamarre sdelamarre closed this Nov 13, 2023
@BJNFNE BJNFNE deleted the adibou2-german-gf-flag branch November 13, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants