You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, BITD bitmaps were pre-converted to match the ScummVM colour
depth. This caused issues in 32-bit mode; you are allowed to change the
palette of an 8-bit image at any time, so pre-converting all 8-bit
images to 32-bit leaves you frozen to whatever palette was in use when
the image was loaded.
The correct way to deal with this is to keep the original bitmap
pixel format, and perform the conversion at widget creation time.
The changes primarily focus on enhancing the handling of bitmap images in the Director engine. This includes modifications to the BitmapCastMember class for handling 1bpp and non-1bpp cases, and the addition of a new function for dithering indexed images. The BITDDecoder class has also been updated to handle pixel color conversion based on the pixel format. Additionally, a new Windows game "lingoexpo" has been added to the detection tables.
Added a new function for dithering indexed images and modified the BitmapCastMember::createWidget function to handle 1bpp and non-1bpp cases.
Added a new Windows game "lingoexpo" with corresponding checksum, size, and version.
Added a comment emphasizing the need for surfaces passed to inkBlitSurface to match the format of the window manager for blit efficiency.
Updated the BITDDecoder class to handle pixel color conversion based on the pixel format and removed the convertPixelIntoSurface function.
Chat with CodeRabbit Bot (@coderabbitai)
If you reply to a review comment from CodeRabbit, the bot will automatically respond.
To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
Note: Review comments are made on code diffs or files, not on the PR overview.
Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Commands (invoked as PR comments)
@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai help to get help.
@coderabbitai resolve to resolve all the CodeRabbit review comments.
Note: For conversation with the bot, please use the review comments on code diffs or files.
CodeRabbit Configration File (.coderabbit.yaml)
You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.