PORTS: DISTS: Add ios7 on-screen icon assets #5407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the iOS port of ScummVM using configure instead of Xcode, the on-screen icons were not copied to the generated bundle. Assets not being application icons or launch images are compiled to an Assets.car file by Xcode and put in the root directory of the application bundle. Generate a Assets.car containg the on-screen icons by running the following command in the dists/ios7 directory: xcrun actool ./Images.xcassets --compile build --platform iphoneos \ --minimum-deployment-target 7.0 --app-icon AppIcon \ --output-partial-info-plist partial.plist \ --launch-image LaunchImage The Assets.car seems to be a proprietary Apple’s archive that first appeared in iOS 7. This commit adds a compiled Assets.car contating the assets to the ios7 dists, just as in the tvos dist. The Assets.car file is then copied to the root directory of the app bundle in the ports.mk file when running "make ios7bundle"
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the iOS port of ScummVM using configure instead of Xcode, the on-screen icons were not copied to the generated bundle. Assets not being application icons or launch images are compiled to an Assets.car file by Xcode and put in the root directory of the application bundle.
Generate a Assets.car containg the on-screen icons by running the following command in the dists/ios7 directory:
xcrun actool ./Images.xcassets --compile build --platform iphoneos \ --minimum-deployment-target 7.0 --app-icon AppIcon \ --output-partial-info-plist partial.plist
--launch-image LaunchImage
The Assets.car seems to be a proprietary Apple’s archive that first appeared in iOS 7.
This commit adds a compiled Assets.car contating the assets to the ios7 dists, just as in the tvos dist. The Assets.car file is then copied to the root directory of the app bundle in the ports.mk file when running "make ios7bundle"