Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOB: add continue to GobConsole #5418

merged 1 commit into from Nov 13, 2023


Copy link

@BJNFNE BJNFNE commented Nov 12, 2023

No description provided.

Copy link

coderabbitai bot commented Nov 12, 2023



The change introduced in the codebase is quite straightforward. A new command, "continue", has been added to the GobConsole class in the Gob namespace. This command is linked to the cmdExit method, allowing users to exit the console by using the "continue" command. No other modifications have been made in this update.


File Path Change Summary
.../gob/console.cpp A new command "continue" has been added to the GobConsole class. The cmdExit method is registered for this command. No other changes have been made.


Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=

Copy link

bluegr commented Nov 12, 2023

I don't understand this. Why are you assigning a new command with a completely different name to cmdExit()?

Copy link
Contributor Author

BJNFNE commented Nov 12, 2023

i saw other engines like Mortevielle are using it.

Copy link

bluegr commented Nov 13, 2023

I see. This goes way back to 2002, with commit f167eaf. Perhaps we should consider moving this to gui/debugger.cpp - it's there, albeit commented out, and it seems it has always been like this:

//registerCmd("continue", WRAP_METHOD(Debugger, cmdExit));

In any case, it won't hurt adding this to gob for uniformity, for now. Thanks!

@bluegr bluegr merged commit 7891b84 into scummvm:master Nov 13, 2023
8 checks passed
@BJNFNE BJNFNE deleted the gobconsole-continue-add branch November 13, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
2 participants