DIRECTOR: Fix filmloop loading for non-bitmap sprites

[kartiksharmakk]

This fixes a graphics glitch in the sonic cemetery scene of Total Distortion. The filmloop was producing extra bounding boxes that led to white artifacts being drawn.

In some cases, particularly in Total Distortion, there could be kInactiveSprite type sprites. We have to skip processing them to avoid the issue.

To reproduce the issue, run:
./scummvm --start-movie="ATD/HD/NJSONIC.DXR"@300 totaldistortion-win

[coderabbitai]

Walkthrough

Walkthrough

The update to the codebase introduces a new conditional logic within the FilmLoopCastMember class. Specifically, it affects how the loadFilmLoopDataD4 function handles sprite processing. The function now checks for inactive sprites and skips them, ensuring that only active sprites of type kBitmapSprite are processed. This change is aimed at improving performance by avoiding unnecessary processing of inactive elements.

Changes

File	Summary
.../director/castmember/filmloop.cpp	Added a conditional check to skip inactive sprites during film loop data loading in loadFilmLoopDataD4.

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[sev-]

Thank you!