Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOB: sorted POTFILES #5426

Merged
merged 1 commit into from Nov 14, 2023
Merged

GOB: sorted POTFILES #5426

merged 1 commit into from Nov 14, 2023

Conversation

BJNFNE
Copy link
Contributor

@BJNFNE BJNFNE commented Nov 13, 2023

No description provided.

Copy link
Contributor

coderabbitai bot commented Nov 13, 2023

Walkthrough

Walkthrough

The changes involve updates to the engines/gob directory of a codebase. Specifically, there has been a duplication of an entry for the file inter_playtoons.cpp within a project file, and the file inter_geisha.cpp has been completely removed from the codebase. These modifications suggest a refactoring or cleanup process within the game engine's directory, possibly for maintenance or to address redundancy.

Changes

File Path Change Summary
.../inter_playtoons.cpp Duplicate entry added in project file
.../inter_geisha.cpp File removed from codebase

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@bluegr
Copy link
Member

bluegr commented Nov 13, 2023

What is the sorting used here? Wouldn't it be simpler to sort these alphabetically?

@BJNFNE
Copy link
Contributor Author

BJNFNE commented Nov 13, 2023

What is the sorting used here? Wouldn't it be simpler to sort these alphabetically?

So First sort after Numbers and then After the Alphabet?

@bluegr
Copy link
Member

bluegr commented Nov 13, 2023

What is the sorting used here? Wouldn't it be simpler to sort these alphabetically?

So First sort after Numbers and then After the Alphabet?

No, because "v" is after "g" and "p". So, alphabetical order would be like this:

engines/gob/inter_geisha.cpp
engines/gob/inter_playtoons.cpp
engines/gob/inter_v2.cpp
engines/gob/inter_v5.cpp
engines/gob/inter_v7.cpp

@BJNFNE
Copy link
Contributor Author

BJNFNE commented Nov 13, 2023

updated

@BJNFNE
Copy link
Contributor Author

BJNFNE commented Nov 13, 2023

@coderabbitai review

@bluegr
Copy link
Member

bluegr commented Nov 14, 2023

Thanks!

@bluegr bluegr merged commit 7d8f56e into scummvm:master Nov 14, 2023
8 checks passed
@BJNFNE BJNFNE deleted the gob-potfiles-sorted branch November 22, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants