Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAB: Fix keymap not being changed in hud elements. #5429

merged 1 commit into from Nov 14, 2023


Copy link

Now the keymap is correctly set to KBM_GAME instead of KBM_UI after Hud elements are closed.

Now the keymap is correctly set to KBM_GAME instead of KBM_UI after
Hud elements are closed.
Copy link

coderabbitai bot commented Nov 14, 2023



The update to the game's code introduces a conditional check to ensure that when the game state switches to STATE_GAME, the key binding mode is correspondingly set to KBM_GAME. This adjustment guarantees that the controls are in the correct configuration for gameplay, likely addressing a bug or oversight where the key binding mode could have been mismatched with the game state.


File Change Summary
engines/crab/game.cpp Added a conditional check to set key binding mode to KBM_GAME when the game state changes to STATE_GAME.


Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=

if (_state == STATE_GAME && g_engine->_inputManager->getKeyBindingMode() != KBM_GAME) {

// This is because game is the first state, the rest are in order
_hud.State(_state - 1);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subtraction operation _state - 1 assumes that the STATE_GAME is the first state and the rest are in order. This could be error-prone if the enum values are changed or new states are added in between. It would be safer to use a switch or mapping to explicitly set the HUD state based on the game state.

switch (_state) {
    case STATE_GAME:
    // Add cases for other states as necessary
        // Handle default case or assert failure

Copy link

sev- commented Nov 14, 2023


@sev- sev- merged commit d84bcb3 into scummvm:master Nov 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
3 participants