Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAB: Fix FPS being shown unnecessarily. #5430

merged 1 commit into from Nov 14, 2023


Copy link

Now fps is only shown if the user types "draw fps" in debugger console.

Now fps is only shown if the user types "draw fps" in debugger console.
Copy link

coderabbitai bot commented Nov 14, 2023



The changes across the files indicate an update to the Crab engine, introducing the ability to toggle the display of frames per second (FPS) during debugging. A new debug draw flag DRAW_FPS has been added, and the console now recognizes an "FPS" parameter to enable this feature. The application's run function has been modified to check this flag before drawing FPS information on the screen.


File(s) Change Summary
.../crab/app.cpp Modified to conditionally draw FPS based on a new debug setting.
.../crab/console.cpp Updated to handle "FPS" parameter, enabling FPS information display for debugging.
.../crab/crab.h Added DRAW_FPS flag to DebugDraw enum to support new FPS drawing feature.


Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=

@hax0kartik hax0kartik merged commit 9fe2300 into scummvm:master Nov 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
2 participants