Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLUDGE: Fix greeting saving and loading in Mandy #5436

merged 1 commit into from Nov 15, 2023


Copy link

No description provided.

Copy link

coderabbitai bot commented Nov 15, 2023



The change in the codebase involves a modification to the file-writing behavior in the savedata.cpp file within the sludge engine. Previously, the code checked if a string was empty before writing it to a file. The update removes this check, leading to the unconditional writing of the string, along with a newline character, to the file. This simplification suggests that an empty string is now considered a valid entry for writing.


File Change Summary
.../sludge/savedata.cpp Removed check for empty string; now writes any string plus a newline to file unconditionally.


Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=

Copy link

sev- commented Nov 15, 2023

Thank you!

@sev- sev- merged commit 4715ba3 into scummvm:master Nov 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
2 participants