Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CREATE_PROJECT: add windows subsystem support to cmake #5439

wants to merge 2 commits into
base: master
Choose a base branch


Copy link

Created as pull request, as I don't have a windows to test this change on.

Copy link

coderabbitai bot commented Nov 16, 2023



The changes across various files involve code refactoring and feature adjustments. In the devtools/create_project files, functions now accept const std::string & to prevent unnecessary string copies, optimizing performance. Additionally, a new conditional check for the WIN32 subsystem has been introduced in cmake.cpp to modify executable generation based on project setup. In the engines/twine files, function names within the Menu and Animations classes have been renamed, indicating a possible shift in functionality or clarification of purpose.


File Summary
devtools/.../cmake.cpp Added conditional check for setting WIN32 subsystem in executables.
Modified featureEnabled and getFeature to take const std::string &.
Renamed functions to better reflect their behavior or purpose.


Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
1 participant