New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QUEEN: Allow improved hebrew font in fallback #5444
Conversation
WalkthroughThe update introduces a language-specific feature for the Hebrew language in the Queen game engine. When detecting games, if Hebrew is selected as the language, the engine now applies an alternative font and an alternative intro, enhancing compatibility and user experience for Hebrew-speaking players. Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
81f9266
to
4f1179c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- engines/queen/detection.cpp (1 hunks)
Additional comments: 1
engines/queen/detection.cpp (1)
- 529-534: The changes correctly add the
GAMEOPTION_ALT_FONT
GUI option for Hebrew language versions of the game when theGF_TALKIE
feature is detected, which indicates a CD version of the game. This is consistent with the pull request's goal to improve Hebrew font support. However, it's important to ensure that theGAMEOPTION_ALT_FONT
option is supported throughout the game's GUI and that the necessary font assets are included and properly loaded when this option is set.
Thanks |
Following #4279
This add the GUI option to select improved hebrew font for fallback detection as well
Summary by CodeRabbit