Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUEEN: Allow improved hebrew font in fallback #5444

Merged
merged 1 commit into from Nov 18, 2023

Conversation

BLooperZ
Copy link
Contributor

@BLooperZ BLooperZ commented Nov 17, 2023

Following #4279
This add the GUI option to select improved hebrew font for fallback detection as well

Summary by CodeRabbit

  • New Features
    • Enhanced game detection to support Hebrew language, including alternative intro and font options for a better localized experience.

Copy link
Contributor

coderabbitai bot commented Nov 17, 2023

Walkthrough

The update introduces a language-specific feature for the Hebrew language in the Queen game engine. When detecting games, if Hebrew is selected as the language, the engine now applies an alternative font and an alternative intro, enhancing compatibility and user experience for Hebrew-speaking players.

Changes

File Change Summary
engines/queen/detection.cpp Added a check for Hebrew language to set GAMEOPTION_ALT_INTRO and GAMEOPTION_ALT_FONT in guiOptions.

🐇🍂 In the fall, as leaves descend,
A Hebrew script now has a friend.
With fonts and intros, games take flight,
In Queen's engine, they shine so bright. 🌟


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between d3c96a6 and 81f9266.
Files selected for processing (1)
  • engines/queen/detection.cpp (1 hunks)

engines/queen/detection.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between d3c96a6 and 4f1179c.
Files selected for processing (1)
  • engines/queen/detection.cpp (1 hunks)
Additional comments: 1
engines/queen/detection.cpp (1)
  • 529-534: The changes correctly add the GAMEOPTION_ALT_FONT GUI option for Hebrew language versions of the game when the GF_TALKIE feature is detected, which indicates a CD version of the game. This is consistent with the pull request's goal to improve Hebrew font support. However, it's important to ensure that the GAMEOPTION_ALT_FONT option is supported throughout the game's GUI and that the necessary font assets are included and properly loaded when this option is set.

@bluegr
Copy link
Member

bluegr commented Nov 18, 2023

Thanks

@bluegr bluegr merged commit f88281a into scummvm:master Nov 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants