Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOB: added french version of Adi 5 in detection #5448

Merged
merged 1 commit into from Nov 18, 2023

Conversation

BJNFNE
Copy link
Contributor

@BJNFNE BJNFNE commented Nov 18, 2023

Summary by CodeRabbit

  • New Features
    • Introduced support for a new game entry "adi5" with relevant metadata for enhanced game detection capabilities.
    • Added a GUI option related to the new game entry for improved user interaction.

Copy link
Contributor

coderabbitai bot commented Nov 18, 2023

Walkthrough

The update introduces a new game entry to the detection tables for the engine "gob," named "adi5." This addition includes necessary metadata such as the game's unique code, file patterns, supported languages, the platform it runs on, and its features. It also specifies which features are not supported and adds a GUI option related to the game.

Changes

Files Changed Summary of Changes
engines/gob/detection/tables_adi5.h Added a new game entry "adi5" with metadata, unsupported features, and a GUI option.

🐇🌟
In the code's woven warren, a new game hops in,
As autumn leaves twirl, let the puzzles begin!
With metadata in place and the GUI set bright,
May "adi5" bring joy and the players delight! 🍂🎮


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c4b63a6 and 8dc9f22.
Files selected for processing (1)
  • engines/gob/detection/tables_adi5.h (1 hunks)
Additional comments: 1
engines/gob/detection/tables_adi5.h (1)
  • 42-60: The new game entry for the French version of "Adi 5" appears to be correctly formatted and follows the existing pattern for game entries in this file. The metadata includes the game's unique identifier, a placeholder for the missing game code, the MD5 checksum of the game file, the language, platform, and a flag indicating the game is unsupported. The GUI options are set to none (GUIO0()), which is consistent with the other entries.

However, the comment on line 49 suggests that the game code is missing. This should be verified and updated if the game code is available to ensure that the game can be properly identified and handled by the engine.

Additionally, the kFeatures640x480 flag is set, indicating that the game runs at a resolution of 640x480. If this is not the correct resolution for the French version of "Adi 5," this should be corrected.

Lastly, the ADGF_UNSUPPORTED flag is set, which means that this game version is not officially supported by the engine. If support has been added and tested, this flag should be updated to reflect the current status of support for the game.

@bluegr
Copy link
Member

bluegr commented Nov 18, 2023

Thanks

@bluegr bluegr merged commit 09072bf into scummvm:master Nov 18, 2023
8 checks passed
@BJNFNE BJNFNE deleted the adi5-504-french branch November 18, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants