AGS: Disable optimized blit paths stretching and flipping #5450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CPU extension optimized paths do not work properly when scaling or flipping the image. Fixing this needs a lot of work, so for now we pre-stretch and pre-flip as a workaround.
fracturehill
force-pushed
the
ags-blit
branch
from
6a6f832
to
6aebe6e
Compare
|
This is a sad story, but it appeared that @wyatt-radkiewicz just walked away from the project and now we have to disable a chunk of his work before the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the optimized blitting paths (SSE2, AVX2, and NEON)
all have issues with scaling and flipping. Due to the complexity
and poor structure of the code, all my attempts at fixing these
problems have so far failed.
This PR effectively quarantines these code paths so that when
a stretch blit or flipping are needed, they are done onto a
temporary surface, which is then blitted using the optimized
paths. This is obviously less than ideal, but with the impeding
release the only other alternative is to disable extension
support entirely, and I'd rather avoid that.