Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGS: Disable optimized blit paths stretching and flipping #5450

merged 1 commit into from Nov 18, 2023


Copy link

Currently, the optimized blitting paths (SSE2, AVX2, and NEON)
all have issues with scaling and flipping. Due to the complexity
and poor structure of the code, all my attempts at fixing these
problems have so far failed.

This PR effectively quarantines these code paths so that when
a stretch blit or flipping are needed, they are done onto a
temporary surface, which is then blitted using the optimized
paths. This is obviously less than ideal, but with the impeding
release the only other alternative is to disable extension
support entirely, and I'd rather avoid that.

The CPU extension optimized paths do not work properly
when scaling or flipping the image. Fixing this needs a lot
of work, so for now we pre-stretch and pre-flip as a
Copy link

sev- commented Nov 18, 2023

This is a sad story, but it appeared that @wyatt-radkiewicz just walked away from the project and now we have to disable a chunk of his work before the release.

@sev- sev- merged commit ee38b13 into scummvm:master Nov 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
2 participants