Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCI: Add detection entries for the German versions of Phantasmagoria 1+2 #547

Merged
merged 1 commit into from Dec 11, 2014

Conversation

@AReim1982
Copy link
Contributor

AReim1982 commented Dec 10, 2014

No description provided.

@bluegr
Copy link
Member

bluegr commented Dec 10, 2014

Thank you for that, but we'll need to adjust the commit message as follows:

  • "german" -> "German"
  • You can't say "add support", cause that implies that the games will be supported after this commit. Therefore, you'll need to specify something like "add detection entries"

Thus, please change the commit message to something like "SCI: Add detection entries for the German versions of Phantasmagoria 1+2"

@AReim1982 AReim1982 changed the title SCI: Add support for german Phantasmagoria 1+2 SCI: Add detection entries for the German versions of Phantasmagoria 1+2 Dec 10, 2014
@AReim1982
Copy link
Contributor Author

AReim1982 commented Dec 10, 2014

;-)

@bluegr
Copy link
Member

bluegr commented Dec 10, 2014

Thanks, but you only changed the title of the pull request, not the commit itself :)

@AReim1982
Copy link
Contributor Author

AReim1982 commented Dec 10, 2014

You was a little bit too fast for me...

@wjp
Copy link
Member

wjp commented Dec 10, 2014

Thanks, but where did you get the version information you give? It seems incomplete, lists garbage VERSION file contents, and also has UTF-8 characters in it (in both the dates and the VERSION contents) instead of plain ascii.

@AReim1982
Copy link
Contributor Author

AReim1982 commented Dec 10, 2014

I had 2 problems:
1: I don't know how to get the version of the exe-files. Windows doesn't provide some infos about the version. Is there any other way to get the correct version of the exe-files?
2: The about-files of all cds of Phantasmagoria 2 contains that cryptic version-string.
-> HEX: 30 30 30 2E 31 00 2E 30 76 FA 0D 0A

@bluegr
Copy link
Member

bluegr commented Dec 10, 2014

We need the information contained in the "VERSION" file in ASCII, for book keeping purposes, to distinguish each version.

  • Phantasmagoria 1 is a SCI2.1 game, so its version will normally be "2.100.002".
  • Phantasmagoria 2 is a SCI3 game, so its version will normally be "3.000.000".
@AReim1982
Copy link
Contributor Author

AReim1982 commented Dec 11, 2014

The "VERSION" files have the following content:
-> Phantasmagoria 1 (German): "1.100.000"
-> Phantasmagoria 2 (German): "000.1 .0vú"

@bluegr
Copy link
Member

bluegr commented Dec 11, 2014

Quite interesting. I suggest you amend your commit accordingly, including this information in the comments of each entry, but please change the version information to plain ASCII (i.e. for Phantasmagoria 2, something like "000.1.0.vu")

@wjp
Copy link
Member

wjp commented Dec 11, 2014

No, that's not very useful. The effect of character encoding is unclear, so I doubt "u" has any useful meaning.

@bluegr
Copy link
Member

bluegr commented Dec 11, 2014

Ah great, the hex values have been added too for Phantasmagoria 2, so the whole version information is there. This looks good to be merged now. Merging.

bluegr added a commit that referenced this pull request Dec 11, 2014
SCI: Add detection entries for the German versions of Phantasmagoria 1+2
@bluegr bluegr merged commit 8cd1b3a into scummvm:master Dec 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.