Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSCI: Add detection entries for the German versions of Phantasmagoria 1+2 #547
Conversation
|
Thank you for that, but we'll need to adjust the commit message as follows:
Thus, please change the commit message to something like "SCI: Add detection entries for the German versions of Phantasmagoria 1+2" |
|
;-) |
|
Thanks, but you only changed the title of the pull request, not the commit itself :) |
|
You was a little bit too fast for me... |
|
Thanks, but where did you get the version information you give? It seems incomplete, lists garbage VERSION file contents, and also has UTF-8 characters in it (in both the dates and the VERSION contents) instead of plain ascii. |
|
I had 2 problems: |
|
We need the information contained in the "VERSION" file in ASCII, for book keeping purposes, to distinguish each version.
|
|
The "VERSION" files have the following content: |
|
Quite interesting. I suggest you amend your commit accordingly, including this information in the comments of each entry, but please change the version information to plain ASCII (i.e. for Phantasmagoria 2, something like "000.1.0.vu") |
|
No, that's not very useful. The effect of character encoding is unclear, so I doubt "u" has any useful meaning. |
|
Ah great, the hex values have been added too for Phantasmagoria 2, so the whole version information is there. This looks good to be merged now. Merging. |
SCI: Add detection entries for the German versions of Phantasmagoria 1+2
AReim1982 commentedDec 10, 2014
No description provided.