Reduce MAXPATHLEN usage #552

pinotree · 2014-12-22T22:17:10Z

Reduce the usage of MAXPATHLEN in engines,

making use of Common::String::format to format strings
reducing sizes of buffers to the actual amount needed

(Ideally, I'd love to not have MAXPATHLEN defined in common/scummsys.h when not provided by the system, but that's a longer work...)


        AGI: use Common::String::format when possible

Use Common::String::format instead of a MAXPATHLEN-sized char[] buffer.


        DRASCULA: use Common::String::format when possible

Use Common::String::format instead of a MAXPATHLEN-sized char[] buffer.


        AGI: use shorter sizes for buffers

Instead of allocate them with MAXPATHLEN as size, just give them the size for the data that are going to be written on them.

bluegr · 2014-12-22T22:41:29Z

Many thanks, the patches look good. Merging


        Merge pull request #552 from pinotree/reduce-maxpathlen

Reduce MAXPATHLEN usage

pinotree added 3 commits Dec 22, 2014

AGI: use Common::String::format when possible

cfd00ad

Use Common::String::format instead of a MAXPATHLEN-sized char[] buffer.

DRASCULA: use Common::String::format when possible

e8fd25e

Use Common::String::format instead of a MAXPATHLEN-sized char[] buffer.

AGI: use shorter sizes for buffers

f29b365

Instead of allocate them with MAXPATHLEN as size, just give them the size for the data that are going to be written on them.

bluegr added a commit that referenced this pull request Dec 22, 2014

Merge pull request #552 from pinotree/reduce-maxpathlen

7827dbd

Reduce MAXPATHLEN usage

bluegr merged commit 7827dbd into scummvm:master Dec 22, 2014

pinotree deleted the pinotree:reduce-maxpathlen branch Jan 24, 2015

scummvm / scummvm

Reduce MAXPATHLEN usage #552

Reduce MAXPATHLEN usage #552

pinotree commented Dec 22, 2014

bluegr commented Dec 22, 2014

scummvm / scummvm

Join GitHub today

Reduce MAXPATHLEN usage #552

Reduce MAXPATHLEN usage #552

Conversation

pinotree commented Dec 22, 2014

bluegr commented Dec 22, 2014