Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Add feature to copy text from console #5649

Merged
merged 3 commits into from Feb 11, 2024
Merged

Conversation

Darkhood148
Copy link
Contributor

Add Feature: Copy text from console

image

@Darkhood148 Darkhood148 changed the title Develop GUI: Add feature to copy text from console Feb 1, 2024
@sev-
Copy link
Member

sev- commented Feb 1, 2024

Thank you! Please follow our commit guidelines, code formatting, indent. Then we will do a deeper review

gui/widgets/edittext.cpp Outdated Show resolved Hide resolved
@bluegr
Copy link
Member

bluegr commented Feb 3, 2024

There are a lot of unneeded whitespace changes (e.g. in edittext.cpp).

Please check our Code formatting guidelines, and adjust accordingly - you will probably need to adjust your IDE's whitespace settings - check our .editorconfig file - this should take care of the whitespace settings. The editorconfig file is supported in all major IDEs - check its website for more.

Redrawing only the affected lines instead of the whole dialog box
@sev-
Copy link
Member

sev- commented Feb 11, 2024

Thank you! All works great now!

@sev- sev- merged commit 1acc434 into scummvm:master Feb 11, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants