Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MORTEVIELLE: added support for DOS system font #580

Closed
wants to merge 2 commits into from

Conversation

chrilith
Copy link
Contributor

Hi,

This is another pull request for DOS System font in Mortevielle. (see #578)
This one is using the common font manager. Now, all engines can make use of the DOS font is needed.

Thanks!

Using the common font manager.
@Strangerke
Copy link
Member

Shouldn't bitmapTable use nullptr instead of 0 for non existing characters?

@chrilith
Copy link
Contributor Author

Well, I took inspiration from the existing consolefont.cpp which has 0 too.
I'm preparing a full charset for this EGA DOS font. So wait a bit if you consider to merge please :)

Thanks!

@chrilith
Copy link
Contributor Author

chrilith commented Feb 1, 2015

And voila! The full DOS charset (code page 858) which may fit most requirements.

(outdated, this code has been removed)

@chrilith
Copy link
Contributor Author

chrilith commented Sep 9, 2015

OK, sorry for the delay. I removed the last commits with the bad font data.

Is it OK now?

@bluegr
Copy link
Member

bluegr commented Sep 9, 2015

There's a follow-up to the original post, "Revisiting VGA fonts":
http://zehfernando.com/2015/revisiting-vga-fonts/

The follow-up links to another page with a more complete DOS font, here:
http://laemeur.sdf.org/fonts/

This includes a "More perfect DOS VGA 437" font, with the following licence:

More Perfect DOS VGA and Less Perfect DOS VGA are both free for all use, commercial and 
non-commercial. IBM designed the glyphs and Zeh Fernando did most of the work converting 
them to TrueType, so I don't claim ownership of anything.

If you use either of the fonts in a project, I'd love to hear about it, and I'd be happy to put
a hyperlink to your project on this page if you send me a note.

Since this font includes all DOS characters, perhaps it would be better to use that instead?

@sev-
Copy link
Member

sev- commented Nov 7, 2015

@chrilith, any update on this?

@chrilith
Copy link
Contributor Author

chrilith commented Nov 9, 2015

Hi @SEV,

Well, I did a rollback to use the first commited font last time.
Didn't get time to dup this new font yet, sorry

@lordhoto
Copy link
Contributor

This does not merge cleanly anymore. We have DOS font data in the AGI engine. It might make sense to re-use this for Mortevielle too. Please open a new PR if you plan to do this. Closing this as rotten for now.

@lordhoto lordhoto closed this Mar 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants