New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MORTEVIELLE: added support for DOS system font #580
Conversation
Using the common font manager.
Shouldn't bitmapTable use nullptr instead of 0 for non existing characters? |
Well, I took inspiration from the existing consolefont.cpp which has 0 too. Thanks! |
And voila! The full DOS charset (code page 858) which may fit most requirements. (outdated, this code has been removed) |
e840a30
to
28d6d9a
Compare
OK, sorry for the delay. I removed the last commits with the bad font data. Is it OK now? |
There's a follow-up to the original post, "Revisiting VGA fonts": The follow-up links to another page with a more complete DOS font, here: This includes a "More perfect DOS VGA 437" font, with the following licence:
Since this font includes all DOS characters, perhaps it would be better to use that instead? |
@chrilith, any update on this? |
Hi @SEV, Well, I did a rollback to use the first commited font last time. |
This does not merge cleanly anymore. We have DOS font data in the AGI engine. It might make sense to re-use this for Mortevielle too. Please open a new PR if you plan to do this. Closing this as rotten for now. |
Hi,
This is another pull request for DOS System font in Mortevielle. (see #578)
This one is using the common font manager. Now, all engines can make use of the DOS font is needed.
Thanks!