Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTROPOLIS: add stubs for numerous third-party plugin modifiers #6059

Merged
merged 9 commits into from
Sep 5, 2024

Conversation

meekee7
Copy link
Contributor

@meekee7 meekee7 commented Aug 18, 2024

Add stubs for modifiers from custom plugins and third-party plugins.

The modifier implementations mostly consist of copypasted boilerplate code, making this PR seem much larger than it is.

In theory more of the plugins could be implemented, such as stubbing out events as suggested in PR #5808. In practice, this would mean endless scope creep. The code at this stage is intended to let games boot by loading the modifier data, or to indicate where such loading would currently fail. Connecting the games to these new plugins in their boot scripts will be done separately as well.

If this PR is already too large, we can try a different approach of adding empty plugins first, then filling the plugins with modifiers in separate PRs.

Modifiers that are not specific to single games are grouped into plugins by their original developer. In the original implementations they were sometimes spread across multiple plugins. Although with mTropolis 2.0, a trend emerged to bundle them into single plugins again.

AXLogic

Third-party plugin developer.
They crafted the AlienScript system as a more powerful alternative to Miniscript.

FTTS

The game Fairy Tale: A True Story - Activity Center has two custom modifiers.

Hoologic

Third-party plugin developer.
The Bitmap plugin is behind the photography feature in the Albert/Ernest series, where it was essential to the games.
The Paint plugin is likely to be found in any game with a painting activity.

KnowWonder

KnowWonder was a game developer, who used their custom plugin in several games.

mLine

Small third-party plugin developer.

RWC

The title Real Wild Child! Australian Rock Music 1950s-90s has four custom modifiers.

Thereware

Third-party plugin developer. Their plugins cover a wide variety of functionality and are very widespread.

@elasota
Copy link
Contributor

elasota commented Sep 5, 2024

Looks OK to me

@elasota elasota merged commit 453d85b into scummvm:master Sep 5, 2024
8 checks passed
@meekee7 meekee7 deleted the mtropo-plugin-modifiers branch September 5, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants