Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle keyboard interrupt like gdb #6083

Closed
wants to merge 2 commits into from

Conversation

john-peterson
Copy link
Contributor

this should handle keyboard interrupt like gdb

there was also a failed git command that silently killed make on my shallow clone despite V=1

@bluegr
Copy link
Member

bluegr commented Aug 30, 2024

Please follow our commit guidelines and code formatting conventions

@sev-
Copy link
Member

sev- commented Aug 30, 2024

Could you please explain purpose of this change? In gdb you normally press Ctrl+C and you get to the gdb prompt. Why adding this platform-dependent getch() and calling exit() in a C++ application?

@bluegr
Copy link
Member

bluegr commented Sep 2, 2024

@john-peterson thanks!

Regarding the git shallow clones fix, it has been merged in-tree in commit 7a72d6b.

Regarding the signal-related change, however, as @sev- mentioned, the behavior that is being introduced is platform specific. We already handle exiting from the application gracefully, so it's unclear why we would want to add such a platform-specific functionality, together with exit().

For the reasons above, I'm closing this, since we didn't get any further feedback. If you can find a good reason to introduce this functionality in a platform-independent manner, feel free to reopen this PR, but please also follow our commit guidelines, as stated above

@bluegr bluegr closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants