Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix termux build #6084

Closed
wants to merge 1 commit into from
Closed

Conversation

john-peterson
Copy link
Contributor

we have to distinguish between gradle and termux builds for android

this works in termux but i am not certain POSIX is unset in gradle

this might break the gradle build

@bluegr
Copy link
Member

bluegr commented Aug 30, 2024

Please follow our commit guidelines and code formatting conventions

@lephilousophe
Copy link
Member

POSIX is defined in configure for all POSIX platforms and Android is amongst them.
This change is not valid at all and I don't understand what it tries to solve.
__ANDROID__ is defined by the Android NDK. I don't see why it would be defined by other toolchains where the Android API is not available.

@bluegr
Copy link
Member

bluegr commented Aug 31, 2024

This PR makes no sense at all, as @lephilousophe mentioned

The Android file system code is selectively disabled, mainly for the SAF permissions warning, but it's included in the rest of the backend code, e.g. backends/platform/android/android.cpp.

It's not clear why these parts of the code have been disabled for termux... is there an issue with the SAF warning? What is the issue that we're trying to solve in termux?

@lephilousophe
Copy link
Member

Closing in favor of #6087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants