GRAPHICS: AGS: Fix ODR problems in AGS and add Clang support #6090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same as in PR#5581
This allows to enable back SIMD support when compiling with it
This allows to enable back SIMD support when compiling with it
|
Nice work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes leftovers following the PR #5581 where AGS code was not touched to apply the same recipe.
Then, the support for Clang is added with proper version checks.
Finally the checks for GCC and Clang version are relaxed for architecture which do not need such checks (ARMv8 for NEON and x86_64 for SSE2).
This is not perfect as old Android ARM cannot benefit from the SIMD code but it allows to widen the support to Android ARM64 and all MacOS platforms at least.