Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MYST3: Fix autosave thumbnail displaying incorrect game state #6100

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

macca8
Copy link
Contributor

@macca8 macca8 commented Sep 5, 2024

When autosaving, an Autosave file is created which often displays a different thumbnail image to the game state saved.

This is a regression from when the engine's tryAutosaving() method was replaced by the global saveAutosaveIfEnabled(), prior to merging ResidualVM with ScummVM.

Currently, a thumbnail of the game screen is generated whenever the user opens a menu, or pauses the game. This thumbnail is saved to _saveThumbnail, then later copied when writing a save file. Works well for regular saves, but not when autosaving.

In the original tryAutosaving() method, the autosave generated its own thumbnail, immediately before calling saveGameState().

Fixed by modifying saveGameState() to enable an autosave to generate a thumbnail of the current game screen, prior to obtaining it from _saveThumbnail for writing to the Autosave file.

Fixes bug 15296.

@bluegr
Copy link
Member

bluegr commented Sep 5, 2024

Nice work, thanks!

@bluegr bluegr merged commit 56d2eb3 into scummvm:master Sep 5, 2024
8 checks passed
@macca8 macca8 deleted the Fix-myst3-autosave-thumbnail branch September 6, 2024 04:53
@macca8 macca8 restored the Fix-myst3-autosave-thumbnail branch September 6, 2024 04:54
@macca8 macca8 deleted the Fix-myst3-autosave-thumbnail branch September 6, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants