MYST3: Fix autosave thumbnail displaying incorrect game state #6100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When autosaving, an Autosave file is created which often displays a different thumbnail image to the game state saved.
This is a regression from when the engine's tryAutosaving() method was replaced by the global saveAutosaveIfEnabled(), prior to merging ResidualVM with ScummVM.
Currently, a thumbnail of the game screen is generated whenever the user opens a menu, or pauses the game. This thumbnail is saved to _saveThumbnail, then later copied when writing a save file. Works well for regular saves, but not when autosaving.
In the original tryAutosaving() method, the autosave generated its own thumbnail, immediately before calling saveGameState().
Fixed by modifying saveGameState() to enable an autosave to generate a thumbnail of the current game screen, prior to obtaining it from _saveThumbnail for writing to the Autosave file.
Fixes bug 15296.