SWORD1/SWORD2: Detect availability of RGB colour support at runtime

[ccawley2011]

This is currently a draft because it uncovers a bug in the PSX video decoder - setOutputPixelFormats needs to be called after loadFile() and before the first frame is decoded, however the PSX decoder decodes the first frame within the load function, meaning that it's not possible to override the default format.

[bluegr]

@ccawley2011 so what are the actions to be taken here? What's stopping you from proceeding with the bugfix?

From what you said, we should:

• Remove readNextPacket() from `PSXStreamDecoder::loadStream()'
• Test PSX videos with this bugfix
• Test PSX SWORD1/SWORD2 videos with the changes from this PR

So... would you like to proceed with this change and fix the bug you identified within the PSX decoder, instead of leaving this PR as draft?

[ccawley2011]

• Remove readNextPacket() from `PSXStreamDecoder::loadStream()'

It's not that easy, since readNextPacket() handles reading the initial sector and creating the audio and video tracks that are needed by loadStream().

[bluegr]

@ccawley2011 I believe that this patch could solve the bug. I've tested it with the PSX version of BS1:

 video/psx_decoder.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/video/psx_decoder.cpp b/video/psx_decoder.cpp
index c7f9f4820a2..bb6d2b5c519 100644
--- a/video/psx_decoder.cpp
+++ b/video/psx_decoder.cpp
@@ -189,6 +189,7 @@ void PSXStreamDecoder::readNextPacket() {
 	Common::SeekableReadStream *sector = 0;
 	byte *partialFrame = 0;
 	int sectorsRead = 0;
+	int64 prevPos = _stream->pos();
 
 	while (_stream->pos() < _stream->size()) {
 		sector = readSector();
@@ -211,6 +212,12 @@ void PSXStreamDecoder::readNextPacket() {
 				if (!_videoTrack) {
 					_videoTrack = new PSXVideoTrack(sector, _speed, _frameCount);
 					addTrack(_videoTrack);
+
+					// If no video track is initialized, we are called
+					// by loadStream(). Stop here, and start rendering
+					// the track from the next call.
+					_stream->seek(prevPos);
+					return;
 				}
 
 				sector->seek(28);

[bluegr]

@ccawley2011: I've committed the patch above for the PSX decoder in 9354d6c.

Please, fix the conflicts in this PR, so that we can proceed with merging it. Thanks!

[bluegr]

Thanks! Looks good, great work!

Merging