Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: Add detection for fpgapirates full game, add movutil name to get it past titlescreen #6381

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

einstein95
Copy link
Contributor

No description provided.

Copy link
Contributor

@rvanlaar rvanlaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good.

Please improve the commit message. Something like:

DIRECTOR: fixes for fpgapirates full game

  • adds detection for full game,
  • movutils xobj dll is known by MovieUtilities,
  • exposed as MovieUtilities on mac and
  • exposed as movieutl on windows.

@bluegr
Copy link
Member

bluegr commented Jan 3, 2025

Also, please split the commit in two: the detection part, and the movutil part. They are two distinct changes

* Add MovieUtilities name for Mac version
* Add alternate Windows DLL name (movieutl)
@einstein95
Copy link
Contributor Author

The code looks good.

Please improve the commit message. Something like:

DIRECTOR: fixes for fpgapirates full game

* adds detection for full game,

* movutils xobj dll is known by MovieUtilities,

* exposed as MovieUtilities on mac and

* exposed as movieutl on windows.

Done

Also, please split the commit in two: the detection part, and the movutil part. They are two distinct changes

Also done

@bluegr
Copy link
Member

bluegr commented Jan 4, 2025

Thanks! All comments have been addressed. This looks good now

@bluegr bluegr merged commit ac06583 into scummvm:master Jan 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants